Draft
Conversation
leducp
force-pushed
the
add_dc_support
branch
from
68597a2 to
66d3c7d
Compare
Fetch DL status at init to compute topology Fetch received times for DC Add sync point in timer API Fix SDO error format when the error is detected by the stack
Cleanup marvin example
leducp
force-pushed
the
add_dc_support
branch
3 times, most recently
from
d223ac0 to
8d67929
Compare
leducp
force-pushed
the
add_dc_support
branch
from
8d67929 to
c477b90
Compare
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against f28fcb2 |
Cleanup a bit the code
leducp
force-pushed
the
add_dc_support
branch
from
413357d to
f28fcb2
Compare
trns1997
reviewed
Feb 28, 2026
| option(DEBUG_DC_INFO "Enable distributed clock info level traces" OFF) | ||
| if (DEBUG_DC_INFO) | ||
| add_compile_definitions(DEBUG_DC_INFO) | ||
| endif() No newline at end of file |
Collaborator
There was a problem hiding this comment.
Suggested change
| endif() | |
| endif() | |
trns1997
reviewed
Feb 28, 2026
| } | ||
|
|
||
| auto& easycat = bus.slaves().at(0); | ||
| auto& easycat = bus.slaves().at(1); |
Collaborator
There was a problem hiding this comment.
revert this when time come
trns1997
reviewed
Feb 28, 2026
|
|
||
| printEntryDescription(bus, ingenia, 0x1600, 0, | ||
| CoE::SDO::information::ValueInfo::DEFAULT | CoE::SDO::information::ValueInfo::MINIMUM | CoE::SDO::information::ValueInfo::MAXIMUM); | ||
| printEntryDescription(bus, ingenia, 0x100A, 0, CoE::SDO::information::ValueInfo::DEFAULT); |
Collaborator
There was a problem hiding this comment.
not sure why this was changed? Did you test this on an ingenia?
trns1997
reviewed
Feb 28, 2026
| bus.waitForState(State::PRE_OP, 3000ms); | ||
|
|
||
|
|
||
| auto map_pdos = [&](uint8_t id) |
Collaborator
There was a problem hiding this comment.
ah high time we create a global method to remap. I have created an issue #302 :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #126