Conversation
hrak
requested review from
CientistaDaWeb,
FarnazBGH,
jpsfalcao,
kasperhendriks,
lanord and
suhasagasthya
…hooks Make ControlPlaneEndpoint optional on CloudStackCluster and CloudStackIsolatedNetwork, allowing the endpoint to be populated dynamically during reconciliation rather than requiring it at creation time. Move port defaulting (6443) from the mutating webhook into the isolated network controller's reconcile loop. Remove mutating webhooks for CloudStackCluster and CloudStackClusterTemplate as they are no longer needed. CC-1861 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
hrak
force-pushed
the
feat/optional-control-plane-endpoint
branch
from
635c48e to
fa7c12a
Compare
suhasagasthya
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a change suggested in the CAPI 1.11 -> 1.12 notes
Summary
ControlPlaneEndpointoptional onCloudStackClusterandCloudStackIsolatedNetwork, allowing endpoint to be populated dynamically during reconciliationCloudStackClusterandCloudStackClusterTemplateChanges
+optionalmarker andomitemptytoControlPlaneEndpointfieldDefault()methods,CustomDefaulterinterfaces, andMutatingWebhookConfigurationcontrolPlaneEndpointfrom required fieldsgetAPIServerPort()helper with default port 6443 fallbackgetAPIServerPort()covering empty, partial, and fully set endpointsTest plan
getAPIServerPort()pass (empty, host-only, port-only, fully set)ControlPlaneEndpointset continue to workControlPlaneEndpointget port defaulted to 6443🤖 Generated with Claude Code