Skip to content

feat: section on widgets - #977

Open
Vtec234 wants to merge 19 commits into
libleanfrom
widgets
Open

Vtec234 wants to merge 19 commits into
libleanfrom
widgets

Conversation

@Vtec234

@Vtec234 Vtec234 commented Oct 25, 2026

Copy link
Copy Markdown
Member

This PR adds a section on widgets to the reference manual.

@Vtec234
Vtec234 added this pull request to stack #978 October 25, 2026 22:35
@Vtec234
Vtec234 requested a review from jcreedcmu October 25, 2026 22:36
@leanprover-bot leanprover-bot added the HTML available HTML has been generated for this PR label Oct 26, 2026
@Vtec234
Vtec234 force-pushed the widgets branch 2 times, most recently from b968b6e to b75d475 Compare October 29, 2026 19:45
@Vtec234
Vtec234 removed this pull request from stack #978 October 29, 2026 19:48
@Vtec234
Vtec234 changed the base branch from reference-manual-web to liblean October 29, 2026 19:49
@Vtec234
Vtec234 added this pull request to stack #985 October 29, 2026 19:49
@github-actions

Copy link
Copy Markdown
Contributor

Preview for this PR is ready! 🎉 (also as a proofreading version). built with commit 97aa44d.

Comment thread Manual/Interaction/Widgets.lean Resolved
Comment thread Manual/Interaction/Widgets.lean Resolved
Comment thread Manual/Interaction/Widgets.lean Resolved
Comment thread Manual/Interaction/Widgets.lean Resolved
Comment thread Manual/Interaction/Widgets.lean Resolved
Comment thread Manual/Interaction/Widgets.lean Resolved
Comment thread Manual/Interaction/Widgets.lean Resolved
Comment thread Manual/Interaction/Widgets.lean Resolved
Comment thread Manual/Interaction/Widgets.lean Resolved
Comment thread Manual/Interaction/Widgets.lean Resolved
Comment thread Manual/Interaction/Widgets.lean Resolved
Comment thread Manual/Interaction/Widgets.lean Resolved

{docstring Widget.WidgetInstance}

Lean can display widgets in two ways: within messages in the {tech}[message log], or as {tech (key := "InfoView panel widget")}[InfoView panels] associated with a source span.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this text belongs higher in the chapter, up near the initial discussion of widgets. That way the reference to panel widgets that I stumbled on earlier will have a higher chance of being understood.

@Vtec234 Vtec234 Nov 10, 2026 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't really intend for this to be read linearly. I am thinking of this chapter (and refman as a whole) as more of a reference that one can jump around to locate relevant technical information efficiently.

Comment thread Manual/Interaction/Widgets.lean Resolved
Comment thread Manual/Interaction/Widgets.lean Resolved
Comment thread Manual/Interaction/Widgets.lean Resolved
Comment thread Manual/Interaction/Widgets.lean Resolved
Comment thread Manual/Interaction/Widgets.lean Resolved
Comment thread Manual/Interaction/Widgets.lean Resolved
Comment thread Manual/Interaction/Widgets.lean Resolved
Comment thread Manual/Interaction/Widgets.lean Resolved
Comment thread Manual/Interaction/Widgets.lean Resolved
Comment thread Manual/Interaction/Widgets.lean Resolved
Comment thread Manual/Interaction/Widgets.lean Resolved
Comment thread Manual/Interaction/Widgets.lean Resolved
open Verso.Genre Manual InlineLean
open Lean Widget

#doc (Manual) "Widgets" =>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having read the whole thing and looked at its place in the ToC, I think this section should have a bit more in the intro to situate it and help readers figure out if it's for them. Can it lead with some use cases and associated screenshots before digging in to editors and InfoViews and React?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I think I would prefer to leave this as-is in this respect. I feel like the manual should mostly provide efficient access to relevant technical information. We can leave motivation and friendlier text to the tutorials.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HTML available HTML has been generated for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants