chore: deprecate liftReflToEq and rel_of_eq_and_refl - #15080
Merged
Conversation
Neither is hooked up to a tactic in core; the only user is Mathlib, which calls `liftReflToEq` directly from `Mathlib.Tactic.CongrM` and `Mathlib.Tactic.CongrExclamation`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CH8QxMAJ7CEKkYq6z2DuUp
github-actions
Bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
mathlib-bors Bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Sep 10, 2026
This PR moves `Lean.MVarId.liftReflToEq` and its helper theorem `Lean.Meta.Rfl.rel_of_eq_and_refl` from core into `Mathlib/Tactic/Relation/Rfl.lean`, where they become `Mathlib.Tactic.liftReflToEq` and `Mathlib.Tactic.rel_of_eq_and_refl`. Mathlib is the only user of either declaration, so core deprecates them in leanprover/lean4#15080. The new names avoid a clash with the deprecated core declarations, so the two call sites in `Mathlib.Tactic.CongrM` and `Mathlib.Tactic.CongrExclamation` no longer use dot notation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01CH8QxMAJ7CEKkYq6z2DuUp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deprecates
Lean.MVarId.liftReflToEqand its helper theoremLean.Meta.Rfl.rel_of_eq_and_refl. Neither is hooked up to a tactic in core, and downstream users should keep their own copies.The only user is Mathlib, which calls
liftReflToEqdirectly fromMathlib.Tactic.CongrMandMathlib.Tactic.CongrExclamation; leanprover-community/mathlib4#43601 moves both declarations there.🤖 Generated with Claude Code
https://claude.ai/code/session_01CH8QxMAJ7CEKkYq6z2DuUp