fix: panic in elan toolchain gc on toolchains without a directory - #207
Merged
Conversation
`Toolchain::is_custom` asserted that the toolchain exists, so `analyze_toolchains` panicked with `assertion failed: self.exists()` whenever `list_toolchains` returned a toolchain whose directory is gone by the time it is inspected — a toolchain deleted manually in between, or a directory name that de-sanitizes into a path outside the toolchains directory. `is_custom` is now answerable for toolchains that do not exist, and `gc` skips them instead of offering to collect them.
Kha
enabled auto-merge (squash)
August 24, 2026 15:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toolchain::is_customasserted that the toolchain exists, soanalyze_toolchainspanicked withassertion failed: self.exists()wheneverlist_toolchainsreturned a toolchain whose directory is gone by the time it is inspected.