Skip to content

feat(ClickSuggestions): support assigning metavariables in the goal - #43597

Draft
JovanGerb wants to merge 1 commit into
leanprover-community:masterfrom
JovanGerb:Jovan-click_suggestions-mvar-matching
Draft

feat(ClickSuggestions): support assigning metavariables in the goal#43597
JovanGerb wants to merge 1 commit into
leanprover-community:masterfrom
JovanGerb:Jovan-click_suggestions-mvar-matching

Conversation

@JovanGerb

Copy link
Copy Markdown
Contributor

This PR lets #click_suggestions give suggestions that instantiate metavariables in the goal.

TODO: improve the filtering so that not all suggestions that add metavariables are filtered out.


Open in Gitpod

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

PR summary 1e48ce6d30

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 1e48ce6).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.
No changes to weak technical debt.

Current commit 1e48ce6d30
Reference commit 08c58d241f

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-meta Tactics, attributes or user commands label Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant