Open
Conversation
— Remove non-working link to keybase.io — Add key ID — Add link to (yet to be created) GitHub repo 'pgp-keys' with the key file 'lbry-key.asc' stored in the master branch — Remove not self-signed PGP key in code box (having a single source for the PGP key and the key ID is a bad habit) — Move security reporting link to the bottom
Member
|
thanks @RubenKelevra for this PR. can you explain why its best to have a separate repo for PGP keys rather than including it directly on the page? |
Author
Sure. The idea is to make it harder for an attacker to modify the binary and the pgp key. If the pgp key is stored in a git on Github either Github itself would need to be compromised or the git needs to be modified, additionally to the webpage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
— Remove non-working link to keybase.io
— Add key ID
— Add raw-link to the key file in pgp-keys
— Remove not self-signed PGP key in code box (having a single source for the PGP key and the key ID is a bad habit)
— Move security reporting link to the bottom
Why I did that
Fixes #1503
To-Do before merge
— A new GitHub repo 'pgp-keys' under lbryio needs to be created
— The public key file needs to be signed by the
0x73000EAE82F4283AAF1FCC516CB639B5FFE02E7Ekey (self-signature)— The signed public key needs to be stored in the master branch of 'pgp-keys' as lbry-key.asc