fix: rename red palette to magenta and add true red palette #1189
Conversation
- Renamed existing red palette to magenta (pinkish-red hues) - Created new red palette based on #F91313 (notification error color) - Updated palette.ts to use magenta for error backgrounds - New red palette provides true red colors for error states Resolves layer5io#602 Signed-off-by: Jeet Burman <[email protected]>
|
@Rajesh-Nagarajan-11 @leecalcote @nebula-aac , I request a review. |
- Changed magenta color values from rose-red to purple-pink shades - magenta[40] now #E600AC (true magenta) instead of #ff385c (rose-red) - magenta palette now uses proper purple-pink spectrum - Addresses reviewer feedback on color accuracy Signed-off-by: Jeet Burman <[email protected]>
|
@saurabhraghuvanshii ,
The magenta palette now uses true purple-pink colors instead of rose-red. The |
|
@jeetburman check shades here https://maketintsandshades.com/#colors=B32700&hashtag=0&steps=10 and issue is to rename exitsing shades without removing old shades because we are using that shades everywhere so it will break our current setup |
I understand. Thank you for clarifying. I will make the necessary changes.. |
|
@jeetburman I would suggest leave this issue solve other open issue. Because minor change can break many websites |
|
If you still trying to solve you have to go with all meshery and layer5 repo to verify your changes |
|
@jeetburman |
I have added my discussion topic in the agenda items... |
3 participants
This PR addresses issue #602 by renaming the existing red palette to magenta and introducing a new true red palette.
Resolves #602
Notes for Reviewers
This PR fixes #602
The existing
redpalette contained pinkish-magenta hues (e.g.,#ff385c,#FFB3B9). This has been renamed tomagentafor semantic accuracy. A newredpalette has been created using#F91313as the base color, which is already used for notification errors and provides true red colors.Changes are backward compatible - the magenta palette retains all the previous red values, and components using error states now benefit from more accurate red colors.
Signed commits