Skip to content

fix(forkchoice-viz): always render finalized block as fully filled #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablodeymo merged 8 commits into from
May 14, 2026
+3 −1
Merged

fix(forkchoice-viz): always render finalized block as fully filled #339

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d9197b3
Completely fill the finalized block node in the forkchoice visualization
conache May 1, 2026
ea2b5ac
Cleanup changes based on initial reviews
conache May 1, 2026
3dd7bd5
Merge branch 'main' into forkchoice-viz-fill-finalized-block-node
conache May 14, 2026
faab73a
Implement suggested changes
conache May 14, 2026
d312910
Revert redundant change
conache May 14, 2026
aea0682
Remove unwanted files
conache May 14, 2026
52330fd
Remove .DS_Store included files
conache May 14, 2026
8f343ba
Merge branch 'main' into forkchoice-viz-fill-finalized-block-node
pablodeymo May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion crates/net/rpc/static/fork_choice.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,12 +391,14 @@

const flatNodes = allDescendants.map(d => {
const roles = nodeRoles(d.data, data);
// Finalized blocks are filled by default, otherwise scale by fork-choice weight.
const isFinalized = roles.includes("finalized");
return {
...d.data,
x: d.x,
y: d.y,
_color: roles.length > 0 ? COLORS[roles[0]] : COLORS.default,
_ratio: weightRatio(d.data, data.validator_count),
_ratio: isFinalized ? 1 : weightRatio(d.data, data.validator_count),
// Colors of secondary roles, in priority order (after the primary).
_haloColors: roles.slice(1).map(r => COLORS[r])
};
Expand Down