fix crash on indication when only gattlib_register_indication() is used - #296
Open
rdmeneze wants to merge 1 commit into
Open
fix crash on indication when only gattlib_register_indication() is used#296rdmeneze wants to merge 1 commit into
rdmeneze wants to merge 1 commit into
Conversation
Indications were being routed through gattlib_on_gatt_notification(), which asserts on connection->notification.thread_pool. That pool only gets created if you called gattlib_register_notification() - if your app only does indications (gattlib_register_indication()), that pool is still NULL and the first real indication crashes the process. Added a gattlib_on_gatt_indication() that uses the indication thread pool instead, and wired the indication signal handler to call that. Signed-off-by: Rafael Dias <rdmeneze@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indications were being routed through
gattlib_on_gatt_notification(), which asserts onconnection->notification.thread_pool. That pool only gets created if you calledgattlib_register_notification()- if your app only does indications (gattlib_register_indication()), that pool is stillNULLand the first real indication crashes the process.Added a
gattlib_on_gatt_indication()that uses the indication thread pool instead, and wired the indication signal handler to call that.