Repository navigation
[Bugfix][Store] Preserve object checksums through HA promotion - #4889
Merged
Merged
Conversation
The durable cleanup tests fill a 1024-byte tenant quota while the default 90% tenant watermark remains enabled. Background eviction can remove the object before the tested cleanup operation, releasing quota early and preventing the expected REMOVE record. Disable tenant watermark eviction in the three affected tests, matching the existing UpsertStart stale-cleanup test. Keep all durability and quota assertions intact. Validation: reproduced all three failures by forcing a tenant eviction pass; the same interleaving passes after the fix. All 131 master_service_ha_test cases and three related CTest targets pass. The affected tests also pass 30 repetitions each, and scoped pre-commit passes.
Icedcoco
marked this pull request as ready for review
October 26, 2026 03:19
Icedcoco
requested review from
00fish0,
Aionw,
Libotry,
XucSh,
YiXR,
stmatengss and
ykwd
as code owners
October 26, 2026 03:19
Aionw
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
HA promotion currently preserves an object's replicas but drops its optional object checksum. This change carries
ObjectPart::checksumthrough OpLog payloads, standby metadata and snapshots, then restores it when publishing recovered objects. It covers the existing checksum diagnostic feature; it does not change checksum calculation or repair historical entries that never stored a checksum.The schema addition uses a compatible field so readers accept older payloads and snapshots. Older records restore with an absent checksum, and older writers still discard the new field, so all writers must be upgraded for checksum continuity.
Related: #3140 added optional object checksum diagnostics and explicitly left HA OpLog continuity out of scope. This PR addresses that HA gap.
Suggested Merge Priority
Module
mooncake-store)Type of Change
How Has This Been Tested?
Test commands:
Test results:
Checklist
AI Assistance Disclosure