Skip to content

Fix godep.md link mislabeled as Go Modules in devel guide index - #9168

Closed
magic-peach wants to merge 1 commit into
kubernetes:mainfrom
magic-peach:docs/fix-godep-link-mislabeled-as-go-modules
Closed

magic-peach wants to merge 1 commit into
kubernetes:mainfrom
magic-peach:docs/fix-godep-link-mislabeled-as-go-modules

Conversation

@magic-peach

Copy link
Copy Markdown

Which issue(s) this PR fixes:
No issue tracks this; found while checking contributors/devel/README.md's dependency management links for accuracy. The second bullet links to godep.md but was titled "Using Go Modules to Manage Dependencies", the exact same title as the bullet directly above it for vendor.md. godep.md documents the old, pre-Go-Modules dependency tool used before Kubernetes 1.14.x, which is exactly what the bullet's own body text already says. Retitled to "Using godep to Manage Dependencies" to match the file it actually links to.

Fixes #

Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: magic-peach
Once this PR has been reviewed and has the lgtm label, please assign thockin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added area/developer-guide Issues or PRs related to the developer guide sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 19, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @magic-peach. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 19, 2026
@skitt

skitt commented Sep 21, 2026

Copy link
Copy Markdown
Member

@kubernetes-prow kubernetes-prow Bot closed this Sep 21, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

@skitt: Closed this PR.

Details

In response to this:

See https://kubernetes.slack.com/archives/C01672LSZL0/p1789992857325439

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/developer-guide Issues or PRs related to the developer guide cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants