credentials: fix cloudflare test after cfSecretMode refactor - #86
Merged
Conversation
Signed-off-by: Tamal Saha <tamal@appscode.com>
The validCFSecret helper was replaced by cfSecretMode (returning a cfAuthMode enum) in #80, but the test still referenced the removed function, breaking the lint/typecheck. Rewrite TestValidCFSecret as TestCFSecretMode to exercise cfSecretMode and assert the selected auth mode. Signed-off-by: Tamal Saha <tamal@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The lint/build job failed with:
The
validCFSecretboolean helper was replaced bycfSecretMode(returning acfAuthModeenum) in #80, but the test added in #84 still referenced the removed function, breaking typecheck/lint.Fix
Rewrote
TestValidCFSecret→TestCFSecretModeto exercisecfSecretModeand assert the selected auth mode. Also captured the behavior changes the refactor introduced:cfSecretModerequires a non-empty token value, so a present-but-empty token now yieldscfAuthInvalid(previously the boolean helper treated it as valid).go test ./pkg/credentials/...andgo vetpass locally.