Skip to content

fix(majors): anchor the @types/node plants on the major, not the patch #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kschlt merged 1 commit into from
Oct 4, 2026
Merged

fix(majors): anchor the @types/node plants on the major, not the patch #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions tests/protections/majors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,14 +159,21 @@ const NODE_26: MajorHarness = {
},
{
name: "the declared @types/node major drifts above the runtime",
find: '"@types/node": "^26.6.2"',
replace: '"@types/node": "^27.0.0"',
// Anchored on the major, not the patch: a find that names `^26.6.2`
// stops occurring the day Dependabot moves the patch, and every such
// bump went red here for a reason that has nothing to do with Node
// (#118). The replacement leaves the rest of the version behind, so
// `^26.6.2` becomes `^27.6.2` — still a caret range, now one major up.
find: '"@types/node": "^26',
replace: '"@types/node": "^27',
mustFail: "every place that pins a Node version pins the same major",
},
{
name: "the @types/node caret range is gone, so its major cannot be read",
find: '"@types/node": "^26.6.2"',
replace: '"@types/node": "latest"',
// `^26.6.2` becomes `latest.6.2`: no caret and no leading major, which
// is the declaration this guard must refuse, whatever the tail reads.
find: '"@types/node": "^26',
replace: '"@types/node": "latest',
mustFail: "every place that pins a Node version pins the same major",
},
],
Expand Down
Loading