Fixed starting under jazzy by copying the patterns from kuka_drivers/kuka_rsi_driver package.#4
Open
destogl wants to merge 1 commit intokroshu:masterfrom
Conversation
…kuka_rsi_driver package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the start on jazzy. There were some old executable names used. Also proposing to add always "type" parameter under controller in the future as the pattern with providing param-file is something that will be used more and more. This will also lead that you don't have to define controller types under controller manager's namespace. We at b»robotized are moving all our projects towards that pattern as it is much easier to maintain the them. For now you have to keep somethings because of the humble support, but still the recommendatation for the future.