Update plugin for proto v0.60 - #8
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the zls proto plugin to align with proto v0.60 by bumping the minimum supported proto version and upgrading the Rust toolchain and PDK/test dependencies, along with updating the shim registry snapshot to the new schema.
Changes:
- Raised the plugin’s
minimum_proto_versionto0.60.0and adjusted defaults usage in outputs. - Upgraded Rust toolchain (pinned) and crate dependencies (proto/extism PDK + test utilities).
- Updated the shims registry snapshot schema keys (
alt_bin→alt_exe,parent→context) and included the new snapshot metadata field.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/snapshots/shims_test__creates_shims.snap | Updates expected shim registry JSON snapshot to v0.60 schema. |
| src/proto.rs | Raises minimum proto version and aligns output defaults / host-env API call shape. |
| rust-toolchain.toml | Pins Rust toolchain to 1.97.0. |
| Cargo.toml | Bumps plugin version and updates PDK/dev dependency versions for proto v0.60. |
| Cargo.lock | Regenerates lockfile for the upgraded dependency set. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The previous WASM was built against an older PDK context shape. Community plugins need to rebuild against the latest APIs to remain compatible with proto v0.60.
This follows the same migration applied in:
Impact
The newly built WASM requires proto 0.60.0 or newer. ZLS version resolution, downloads, installation, metadata, and shims continue to use the same plugin interface.
Validation
cargo fmt --all --checkcargo clippy --workspace --all-targetscargo build --release --target wasm32-wasip1PROTO_LOOKUP_DIR=/opt/homebrew/bin cargo test --no-default-features(21 tests passed)git diff --check