Skip to content

Remove Enable template argument from AccessTraits - #1425

Closed
aprokop wants to merge 1 commit into
kokkos:masterfrom
aprokop:remove_enable_from_access_traits
Closed

aprokop wants to merge 1 commit into
kokkos:masterfrom
aprokop:remove_enable_from_access_traits

Conversation

@aprokop

@aprokop aprokop commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@aprokop aprokop added the backward incompatible Modifications that may break users' code label Nov 2, 2026

@dalg24 dalg24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@aprokop

aprokop commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

Why?

There's no point in that parameter. We don't expect users to specify it, and we don't use it internally. The only use was to use it for enable_if prior to C++20.

@masterleinad

Copy link
Copy Markdown
Contributor

@aprokop

aprokop commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

deal.II uses the Enable template argument, see dealii/dealii@d0ff8b3/include/deal.II/arborx/access_traits.h#L751-L779.

OK. Guess we keeping it around, until at least ArborX 3.

@aprokop aprokop closed this Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backward incompatible Modifications that may break users' code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants