Skip to content

chore: remove Pro banner, GitHub link, download button, and MENA region#4398

Closed
brlanweb wants to merge 0 commit into
koala73:mainfrom
brlanweb:main
Closed

chore: remove Pro banner, GitHub link, download button, and MENA region#4398
brlanweb wants to merge 0 commit into
koala73:mainfrom
brlanweb:main

Conversation

@brlanweb

Copy link
Copy Markdown
  • Remove ProBanner component from App.ts
  • Remove GitHub link and stars from header
  • Remove download app button from header
  • Remove MENA region from region selector

Summary

Type of change

  • Bug fix
  • New feature
  • New data source / feed
  • New map layer
  • Refactor / code cleanup
  • Documentation
  • CI / Build / Infrastructure

Affected areas

  • Map / Globe
  • News panels / RSS feeds
  • AI Insights / World Brief
  • Market Radar / Crypto
  • Desktop app (Tauri)
  • API endpoints (/api/*)
  • Config / Settings
  • Other:

Checklist

  • Tested on worldmonitor.app variant
  • Tested on tech.worldmonitor.app variant (if applicable)
  • New RSS feed domains added to api/rss-proxy.js allowlist (if adding feeds)
  • No API keys or secrets committed
  • TypeScript compiles without errors (npm run typecheck)

Documentation Alignment Checklist

  • Claim ledger attached or linked
  • All required Audit Council role signoffs attached
  • Generated docs regenerated from proto where applicable
  • Fixture-backed examples recomputed
  • Redis writers/readers enumerated for every documented key

Screenshots

@vercel

vercel Bot commented Jun 24, 2026

Copy link
Copy Markdown

@brlanweb is attempting to deploy a commit to the World Monitor Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the trust:caution Brin: contributor trust score caution label Jun 24, 2026
@greptile-apps

greptile-apps Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR strips four UI features: the Pro banner, the GitHub link with star counter, the download-app button, and the MENA region from the region selector. The ProBanner and GitHub/download removals are clean, but the MENA removal is incomplete — resolveUserRegion() in src/utils/user-location.ts still maps Middle East timezones and coordinates to 'mena', and VIEW_VALUES in urlState.ts still accepts ?view=mena as valid.

  • ProBanner / GitHub / Download: import and call site removed from App.ts and panel-layout.ts; the initDownloadDropdown event-handler function gracefully no-ops when its elements are gone.
  • MENA region selector: removed from both the desktop <select> and the mobile bottom sheet, but the region-resolution utilities that can produce 'mena' were not updated, leaving mobile users in the Middle East with a blank/mismatched region dropdown on first load, and shared ?view=mena links silently broken.
  • Orphaned CSS: .github-link rules in main.css and rtl-overrides.css are now dead and can be deleted.

Confidence Score: 3/5

The ProBanner and GitHub/download removals are safe, but the MENA region removal is incomplete and leaves mobile users in the Middle East with a broken region selector on first load.

The region-resolution utilities and URL state validator were not updated alongside the UI removal, leaving a broken experience for Middle East users on mobile and invalidating shared links with ?view=mena.

src/utils/user-location.ts and src/utils/urlState.ts need updating to remove all mena references and remap Middle East resolution to a valid region.

Important Files Changed

Filename Overview
src/App.ts Removes the showProBanner call and its import — straightforward cleanup with no side effects on the rest of the boot sequence.
src/app/panel-layout.ts Removes GitHub stars fetch, GitHub link, download button, and MENA option from both the desktop select and the mobile bottom sheet; the MENA removal is incomplete — resolveUserRegion() and urlState VIEW_VALUES still produce mena, causing a blank/incorrect region select for Middle East users on mobile and for shared ?view=mena URLs.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[App.init] --> B[resolveUserRegion]
    B --> C{Region resolved}
    C -->|mena via Middle East TZ or coords| D[state.resolvedLocation = mena]
    C -->|other region| E[state.resolvedLocation = valid region]
    D --> F[panelLayout.init]
    E --> F
    F --> G{isMobile?}
    G -->|yes| H[MapContainer view = mena]
    G -->|no| I[MapContainer view = global]
    H --> J[map.onStateChanged fires]
    J --> K[regionSelect.value = mena]
    K --> L[No matching option - select shows blank]
    I --> M[regionSelect in sync]
    N[URL ?view=mena] --> O[urlState VIEW_VALUES includes mena]
    O --> P[Parsed as valid view]
    P --> Q[map.setView mena]
    Q --> K
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[App.init] --> B[resolveUserRegion]
    B --> C{Region resolved}
    C -->|mena via Middle East TZ or coords| D[state.resolvedLocation = mena]
    C -->|other region| E[state.resolvedLocation = valid region]
    D --> F[panelLayout.init]
    E --> F
    F --> G{isMobile?}
    G -->|yes| H[MapContainer view = mena]
    G -->|no| I[MapContainer view = global]
    H --> J[map.onStateChanged fires]
    J --> K[regionSelect.value = mena]
    K --> L[No matching option - select shows blank]
    I --> M[regionSelect in sync]
    N[URL ?view=mena] --> O[urlState VIEW_VALUES includes mena]
    O --> P[Parsed as valid view]
    P --> Q[map.setView mena]
    Q --> K
Loading

Reviews (1): Last reviewed commit: "chore: remove Pro banner, GitHub link, d..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

trust:caution Brin: contributor trust score caution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant