Fix temp directory leak in getDelve#1665
Open
SebTardif wants to merge 1 commit into
Open
Conversation
getDelve creates a temp directory containing a git clone of Delve and the built binary. The caller removes filepath.Dir(delveBinary), which only deletes .../bin/<os_arch>/ and leaves the clone directory and temp root behind. On a 1GB codebase with frequent debug builds, this leaks megabytes of temp files per build. Return the temp root from getDelve so the caller can clean up the entire directory tree. Also add deferred cleanup on error paths inside getDelve itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
getDelvecreates a temp directory with this layout:The caller cleans up with
os.RemoveAll(filepath.Dir(delveBinary)), which resolves to.../bin/linux_amd64/, only the deepest subdirectory. The git clone and temp root are leaked on every debug build.Additionally, 3 of 4 error paths inside
getDelve(afterMkdirTemp) skip cleanup entirely.Fix
(binaryPath, cleanupDir, error)fromgetDelveso the caller canos.RemoveAllthe actual temp root.getDelvethat runs on any error path (disabled on success via asuccessflag).Testing
gofmt: no issuesgo vet ./pkg/build/...: passgo build ./...: passgo test ./pkg/build/... -count=1: passBug introduced in
Commit
1c83f790fin #1320 refactoredgetDelvefromgo install(flat directory) to git-clone +go build(nested directories) without updating the caller's cleanup path.