-
Notifications
You must be signed in to change notification settings - Fork 35
Redirect for GitHub page #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughA single HTML file migration redirects the documentation site to a new location using meta refresh and canonical link tags, updates the header messaging to indicate the move, and disables original interactive content through HTML comments. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/index.html (2)
12-21: Consider page weight with commented code.While commenting out the script is correct for the redirect, keeping commented content increases the page size. Since the PR description mentions this is "for now," this is acceptable for a temporary state to allow easy rollback.
If this redirect becomes permanent, consider removing the commented content entirely to minimize page weight and load time.
32-231: Consider removing commented content if redirect becomes permanent.The commented-out content serves as a backup for potential rollback, which aligns with the "for now" mention in the PR description. However, if this redirect becomes permanent, removing this content would reduce page size from ~10KB to <1KB, improving load time for users being redirected.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/index.html
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-12-24T08:53:44.026Z
Learnt from: phillipc
Repo: knockout/tko PR: 227
File: tko.io/src/docs/binding-context/binding-syntax.md:29-29
Timestamp: 2025-12-24T08:53:44.026Z
Learning: In the TKO repository's tko.io documentation site, which uses Eleventy (11ty) as the static site generator, Markdown links should point to directory-style URLs with trailing slashes (e.g., `../custom-bindings/`) rather than to the source `.md` files. Eleventy automatically transforms each Markdown file into a directory containing an `index.html` file for cleaner URLs, so `custom-bindings.md` becomes accessible at `custom-bindings/` in the built site.
Applied to files:
docs/index.html
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: testheadless (22.x, on)
- GitHub Check: testheadless (22.x, off)
🔇 Additional comments (2)
docs/index.html (2)
26-26: Excellent user communication.The updated header clearly communicates the site migration and provides a clickable link. This ensures users understand what's happening even if the redirect is delayed or blocked.
5-6: Redirect implementation is correct.The meta refresh and canonical link tags properly implement the redirect to the new site. Both
https://www.tko.ioandhttps://tko.ioare accessible and serve identical content, so using the www variant consistently is appropriate and maintains SEO best practices through the canonical link.
brianmhunt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 it looks good, should merge once the updated tko.io is out in the world.
Summary by CodeRabbit
Chores
✏️ Tip: You can customize this high-level summary in your review settings.