Skip to content

chore(KNO-12588): Add information about test run trigger frequency behavior#1388

Open
rachael-t wants to merge 2 commits intomainfrom
rt-kno-12588-trigger-frequency-callout
Open

chore(KNO-12588): Add information about test run trigger frequency behavior#1388
rachael-t wants to merge 2 commits intomainfrom
rt-kno-12588-trigger-frequency-callout

Conversation

@rachael-t
Copy link
Copy Markdown
Contributor

@rachael-t rachael-t commented Apr 10, 2026

@linear
Copy link
Copy Markdown

linear bot commented Apr 10, 2026

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Apr 10, 2026 6:07pm

Request Review

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk LOW: Adds a callout and inline note clarifying that trigger frequency settings are not enforced during dashboard test runs.

Reasons

  • Only 2 .mdx content files are modified, both within the same content/send-notifications/ section
  • Small diff with 24 additions and 1 deletion — well under the 50-line threshold
  • No new pages, sidebar changes, component changes, or image additions
  • No .ts/.tsx component, layout, lib, or config files are touched
  • Author (rachael-t) is a known repository contributor and team member

Notes

  • The new <Callout> in debugging-workflows.mdx uses inline <a> tags for links — worth confirming these render correctly in the preview deployment (they appear standard for this codebase's callout pattern)
  • The rewritten paragraph in testing-workflows.mdx replaces the previous wording; a quick read-through confirms the meaning is preserved and improved
Open in Web View Automation 

Sent by Cursor Automation: Docs PR classifier

@rachael-t rachael-t requested a review from a team April 10, 2026 18:10
@cellomatt
Copy link
Copy Markdown
Member

I'd be curious if others have thoughts, but IMO the "some workflow settings" language is a bit confusing here because it implies that there might be other settings in addition to trigger frequency that are ignored but which we don't list here.

I wonder whether a better place to put this would just be as a callout directly on the trigger frequency docs? https://docs.knock.app/send-notifications/triggering-workflows/overview#controlling-workflow-trigger-frequency

That feels like the place where you'd most want to see this.

@rachael-t
Copy link
Copy Markdown
Contributor Author

@cellomatt yeah that's a good point on the use of "some workflow settings" language and I can adjust if others agree!

I added it to these two pages because this gotcha really only surfaces when using the test runner or looking at the debugger (and it's not obvious from the debugger why it's happening). I considered the trigger frequency page but it's already pretty sparse and I didn't want to add confusion there. Also hoping that having it on these pages also helps our agent surface it when customers are troubleshooting. Curious what others think though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants