chore(KNO-12588): Add information about test run trigger frequency behavior#1388
chore(KNO-12588): Add information about test run trigger frequency behavior#1388
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Risk LOW: Adds a callout and inline note clarifying that trigger frequency settings are not enforced during dashboard test runs.
Reasons
- Only 2
.mdxcontent files are modified, both within the samecontent/send-notifications/section - Small diff with 24 additions and 1 deletion — well under the 50-line threshold
- No new pages, sidebar changes, component changes, or image additions
- No
.ts/.tsxcomponent, layout, lib, or config files are touched - Author (
rachael-t) is a known repository contributor and team member
Notes
- The new
<Callout>indebugging-workflows.mdxuses inline<a>tags for links — worth confirming these render correctly in the preview deployment (they appear standard for this codebase's callout pattern) - The rewritten paragraph in
testing-workflows.mdxreplaces the previous wording; a quick read-through confirms the meaning is preserved and improved
Sent by Cursor Automation: Docs PR classifier
|
I'd be curious if others have thoughts, but IMO the "some workflow settings" language is a bit confusing here because it implies that there might be other settings in addition to trigger frequency that are ignored but which we don't list here. I wonder whether a better place to put this would just be as a callout directly on the trigger frequency docs? https://docs.knock.app/send-notifications/triggering-workflows/overview#controlling-workflow-trigger-frequency That feels like the place where you'd most want to see this. |
|
@cellomatt yeah that's a good point on the use of "some workflow settings" language and I can adjust if others agree! I added it to these two pages because this gotcha really only surfaces when using the test runner or looking at the debugger (and it's not obvious from the debugger why it's happening). I considered the trigger frequency page but it's already pretty sparse and I didn't want to add confusion there. Also hoping that having it on these pages also helps our agent surface it when customers are troubleshooting. Curious what others think though! |


Description
Adds information to the docs (testing workflows and debugging workflow pages) to clarify that trigger frequency settings are not enforced during test runs.
https://docs-git-rt-kno-12588-trigger-frequency-callout-knocklabs.vercel.app/send-notifications/testing-workflows#the-workflow-test-runner
https://docs-git-rt-kno-12588-trigger-frequency-callout-knocklabs.vercel.app/send-notifications/debugging-workflows#understanding-workflow-execution-behavior
Tasks
KNO-12588