Modernize golangci-lint config - #35
Merged
Merged
Conversation
- Add a .golangci.yml (v2) in place of inline golangci-lint flags in the Makefile lint target - Enable bodyclose and prealloc linters alongside unparam - Use linters.exclusions.paths for generated/client/vendor - Use gofumpt + goimports formatters (gofumpt is a stricter gofmt superset) - Apply resulting gofumpt formatting and simplify an embedded-field selector flagged by staticcheck (QF1008) Signed-off-by: Tamal Saha <tamal@appscode.com>
Run `make gen fmt` to pick up the EnvVarSource fileKeyRef field from the updated Kubernetes libraries. Fixes the verify-gen CI failure (generated files out of date). Signed-off-by: Tamal Saha <tamal@appscode.com>
The addon/v1alpha1 package was imported both normally and as a blank import; the normal import already runs its init, so drop the redundant blank import (staticcheck ST1019). Signed-off-by: Tamal Saha <tamal@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makefile lint target
flagged by staticcheck (QF1008)
Signed-off-by: Tamal Saha tamal@appscode.com