Fix communication with standard reprapHost-Software#135
Open
jschleic wants to merge 4 commits intokliment:masterfrom
Open
Fix communication with standard reprapHost-Software#135jschleic wants to merge 4 commits intokliment:masterfrom
jschleic wants to merge 4 commits intokliment:masterfrom
Conversation
The host software obviously expects ok and the coordinates to be in the same line and the coordinates separated with spaces.
to work with standard host software
According to http://reprap.org/wiki/G-code#Replies_from_the_RepRap_machine_to_the_host_computer replies have to start with one of 'ok', 'rs', '!!', '//'. Actually the current RepRap standard software fails communicating with Sprinter, because it sends 'T0' in the beginning to select a Extruder.
use spaces as indentation consistently
Contributor
Author
|
Any comments / progress on this? What host software(s) are you using? |
Paul3899
approved these changes
Feb 18, 2022
Paul3899
approved these changes
Feb 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm currently using Sprinter together with the standard reprap host software at [1](version 20111115). There are several modifications required to make this host software communicate with Sprinter.
One problem is, that the host software gets confused with line numbering if several lines are returned as reply (like in the 'unknown command' or temperature reporting case of M109).
According to http://reprap.org/wiki/G-code#Replies_from_the_RepRap_machine_to_the_host_computer
there should be only replies starting with one of 'ok', 'rs', '!!', '//'. So I modified replies not starting with ok to be comments starting with '//' and modified the M114 reply to be consistent with the host software and with the format reported by M105.
Please test those modifications with your host software and merge them into master, if appropriate.
[1] https://github.com/reprap/release