Add Laravel 13 support#123
Open
pktharindu wants to merge 3 commits into
Open
Conversation
Laravel 13 hardened Model::bootIfNotBooted to throw a LogicException when a new instance of a model is constructed while that model is itself booting. Model::observe() instantiates the model via new static, so calling static::observe(Observer::class) from a trait boot method now triggers re-entrant booting and breaks applications upgrading to Laravel 13. Register the observer's individual event listeners directly via static::created/updated/deleted/restored using class@method strings instead, which avoids constructing the model and matches the dispatch pattern Laravel uses internally in registerObserver().
Author
|
@kirkbushell could you review this when you have a second? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
^13.0to the illuminate/* constraints, branched from12.0.1.While testing against a Laravel 13 app I hit Laravel 13's new boot guard:
Model::observe()callsnew static, and constructing a model while it's still booting now throws aLogicException. Sostatic::observe(Observer::class)from a trait boot method blows up.Switched
HasCounts,HasSums, andHasValuesto register the listeners directly viastatic::created/updated/deleted/restoredwithClass@methodstrings — same as whatregisterObserver()does internally, just without thenew static. Therestoredlistener now only registers whenSoftDeletesis on the model, otherwise Laravel complains the event isn't observable.Tested with the count/sum/value cache traits in a real L13 app; observers fire as before.