Add cross-platform support for ffmpeg direct download - #241
Open
TaylorMcGinnis wants to merge 1 commit into
Open
Add cross-platform support for ffmpeg direct download#241TaylorMcGinnis wants to merge 1 commit into
TaylorMcGinnis wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #230
This adds support for downloading the correlated static binary file, based on the current
TARGETPLATFORM/ CPU architecture.I did not have a non-arm machine to test this change with. Testing should be done on at least an amd64 machine before merging to avoid a major regression.
I tested this on my M1 Mac being used as a server, which is running ReadMeABook via docker inside a Linux VM. I didn't want to reinvent how the ffmpeg/ffprobe binaries are downloaded, so this follows the same pattern and expands support to all architectures with corresponding binaries from the same release page: https://johnvansickle.com/ffmpeg/releases/