Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6728
📑 Description
IOHandler's template-function parser previously dropped empty containers ([],{},()) and booleanFalsepositional arguments due to an overly restrictive truthiness guard. This caused subsequent arguments to shift left, leading to parameter mismatch or unexpectedTypeErrorexceptions during workflow evaluation.Changes Made
keep/iohandler/iohandler.py: Replaced flawed check withif _arg is not None:. Ensures all valid evaluated arguments ("",0,0.0,False,[],{},()) are preserved positionally.tests/test_iohandler.py: Added unit testtest_iohandler_does_not_drop_falsy_argumentsverifyingkeep.lenandkeep.eqon empty lists, dicts, tuples, and booleanFalse.✅ Checks
ℹ Additional Information
Fixes parameter shifting and unexpected TypeErrors when workflows pass falsy collections or boolean
Falseintokeep.*functions.