fix: prevent incident table horizontal overflow from long summaries#6085
Open
Aladex wants to merge 1 commit intokeephq:mainfrom
Open
fix: prevent incident table horizontal overflow from long summaries#6085Aladex wants to merge 1 commit intokeephq:mainfrom
Aladex wants to merge 1 commit intokeephq:mainfrom
Conversation
|
@Aladex is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6083
When an incident has a long AI-generated summary, the "Incident" column stretches the table beyond the viewport.
FormattedContentrenders summary as HTML viadangerouslySetInnerHTML, producing block-level elements (<p>,<ul>) that create their own block formatting context.line-clampon the outer container cannot penetrate into these child elements, so the text is never clamped — and the table cell grows unbounded.Changes
FormattedContent.tsx: Addplainprop that strips HTML tags and renders as plain inline text, allowingline-clampto work correctlyincidents-table.tsx: Useplainprop onFormattedContentfor the summary, addoverflow-hiddenon the<td>viameta.tdClassNameto prevent the cell from stretching the tableTest plan
plainprop, which is only used in the table)