fix: Fix duplicate key issue when assigning key to edit#644
Merged
Conversation
editedit
Owner
|
Thank you so much for the PR! I'll merge after the workflows run. |
Contributor
Author
|
Thanks for the quick action! Glad we got it sorted. I'm kinda surprised this bug went totally unnoticed since that last PR. I guess no one was trying to rebind |
1 task
|
Thanks for fixing this! I originally reported the issue and simply lived with it. Guess not many people use different keyboard layouts and want to rebind those keys :D |
kdheepak
added a commit
that referenced
this pull request
Dec 19, 2025
## 🤖 New release * `taskwarrior-tui`: 0.26.4 -> 0.26.5 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.26.5](v0.26.4...v0.26.5) - 2025-12-18 ### Added - add desktop entry under docs ([#650](#650)) - help screen shows user keybindings ([#645](#645)) ### Fixed - Fixes duplicate key bug when assigning key to `edit` ([#644](#644)) - README.md typo ([#640](#640)) ### Other - *(setup)* add just recipes for local test data ([#646](#646)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw there was a solution for this problem in #585, but it seems like that PR was refactoring the key config system, and then it lost steam, leaving the original issue (#579) unfixed.
This PR cherry-picks the commit that actually fixes the problem. Refactoring the key config is best left to another PR; but we should fix this bug ASAP, since it makes rebinding the
editcommand impossible.