Skip to content

fix: Fix duplicate key issue when assigning key to edit#644

Merged
kdheepak merged 3 commits into
kdheepak:mainfrom
ficd0:fix-edit-keyconfig
Nov 26, 2025
Merged

fix: Fix duplicate key issue when assigning key to edit#644
kdheepak merged 3 commits into
kdheepak:mainfrom
ficd0:fix-edit-keyconfig

Conversation

@ficd0

@ficd0 ficd0 commented Nov 26, 2025

Copy link
Copy Markdown
Contributor

I saw there was a solution for this problem in #585, but it seems like that PR was refactoring the key config system, and then it lost steam, leaving the original issue (#579) unfixed.

This PR cherry-picks the commit that actually fixes the problem. Refactoring the key config is best left to another PR; but we should fix this bug ASAP, since it makes rebinding the edit command impossible.

@ficd0 ficd0 changed the title Fix duplicate key issue when assigning key to edit fix: Fix duplicate key issue when assigning key to edit Nov 26, 2025
@kdheepak

Copy link
Copy Markdown
Owner

Thank you so much for the PR! I'll merge after the workflows run.

@kdheepak kdheepak merged commit 063040a into kdheepak:main Nov 26, 2025
16 of 17 checks passed
@kdheepak kdheepak mentioned this pull request Nov 26, 2025
@ficd0 ficd0 deleted the fix-edit-keyconfig branch November 26, 2025 20:33
@ficd0

ficd0 commented Nov 26, 2025

Copy link
Copy Markdown
Contributor Author

Thanks for the quick action! Glad we got it sorted. I'm kinda surprised this bug went totally unnoticed since that last PR. I guess no one was trying to rebind edit until now, lol.

@BeCracked

Copy link
Copy Markdown

Thanks for fixing this!

I originally reported the issue and simply lived with it. Guess not many people use different keyboard layouts and want to rebind those keys :D

kdheepak added a commit that referenced this pull request Dec 19, 2025
## 🤖 New release

* `taskwarrior-tui`: 0.26.4 -> 0.26.5

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[0.26.5](v0.26.4...v0.26.5)
- 2025-12-18

### Added

- add desktop entry under docs
([#650](#650))
- help screen shows user keybindings
([#645](#645))

### Fixed

- Fixes duplicate key bug when assigning key to `edit`
([#644](#644))
- README.md typo
([#640](#640))

### Other

- *(setup)* add just recipes for local test data
([#646](#646))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants