Skip to content

fix(core): omit stale responses lite include #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ComputerByte wants to merge 1 commit into from
Closed

fix(core): omit stale responses lite include #626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 30 additions & 20 deletions code-rs/core/src/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,18 @@ fn should_store_responses(
!request_family.use_responses_lite && prompt.store
}

fn response_include_for_request(
store: bool,
use_responses_lite: bool,
has_reasoning: bool,
) -> Vec<String> {
if (!store || use_responses_lite) && has_reasoning {
vec!["reasoning.encrypted_content".to_string()]
} else {
Vec::new()
}
}

fn is_server_overloaded_error(error: &Error) -> bool {
matches!(error.code.as_deref(), Some("server_is_overloaded"))
}
Expand Down Expand Up @@ -911,16 +923,11 @@ impl ModelClient {
attempt += 1;

let reasoning = self.current_reasoning_param(&request_family, effective_effort);
let mut include: Vec<String> = if (!store || request_family.use_responses_lite)
&& reasoning.is_some()
{
vec!["reasoning.encrypted_content".to_string()]
} else {
Vec::new()
};
if request_family.use_responses_lite {
include.push("codex-lite".to_string());
}
let include = response_include_for_request(
store,
request_family.use_responses_lite,
reasoning.is_some(),
);

let service_tier = self
.config
Expand Down Expand Up @@ -1410,16 +1417,11 @@ impl ModelClient {
let reasoning = self.current_reasoning_param(&request_family, effective_effort);
// Request encrypted COT if we are not storing responses,
// otherwise reasoning items will be referenced by ID
let mut include: Vec<String> = if (!store || request_family.use_responses_lite)
&& reasoning.is_some()
{
vec!["reasoning.encrypted_content".to_string()]
} else {
Vec::new()
};
if request_family.use_responses_lite {
include.push("codex-lite".to_string());
}
let include = response_include_for_request(
store,
request_family.use_responses_lite,
reasoning.is_some(),
);

let text = text_template.clone();

Expand Down Expand Up @@ -3387,6 +3389,14 @@ mod tests {
assert!(!should_store_responses(&prompt, &provider, &family));
}

#[test]
fn responses_lite_include_uses_public_response_fields_only() {
let include = response_include_for_request(false, true, true);

assert_eq!(include, vec!["reasoning.encrypted_content".to_string()]);
assert!(!include.iter().any(|field| field == "codex-lite"));
}

#[test]
fn responses_storage_is_not_forced_for_azure_provider() {
let prompt = Prompt::default();
Expand Down