chore(web): delete unreachable legacy room and search UI - #98
Conversation
ADR 0006 removed chat and room UI from the product surface. The pages at
app/rooms/, app/rooms/admin/, app/rooms/[slug]/ and app/search/ call
redirect("/") unconditionally with no env gate, so their entire component
trees have been unreachable since that change.
Deleted (verified by grep to have no remaining importers):
- components/room-view.tsx (2895 lines) - no importers
- components/room-composer.tsx (983 lines) - imported only by room-view
- components/rooms-browser.tsx (795 lines) - no importers
- components/app-shell.tsx (597 lines) - imported only by the four dead views
- components/room-admin-view.tsx (243 lines) - no importers
- components/search-view.tsx (225 lines) - no importers
- components/command-palette.tsx (169 lines) - imported only by app-shell
- components/operations-chart.tsx (36 lines) - no importers
Pruned 722 lines of lib/demo-data.ts whose only consumers were the deleted
components: demoOrganisation, demoPeople, demoAgents, demoRooms,
demoDirectRooms, roomIdBySlug, demoAlerts, roomTimeline, needsAttention,
activeIncidents, investigationQueue, platformHealth, operationsTrend and
searchResults.
Deliberately kept:
- The four redirect page files. Removing them would turn a working redirect
into a 404 for anyone holding an old /rooms or /search bookmark.
- components/investigation-view.tsx, components/integration-view.tsx and
components/workflows-view.tsx. These are reachable when
MUSTER_DEMO_MODE=true and are a deliberate demo surface, not dead code.
- lib/demo-data.ts exports activeInvestigation, integrationData, workflows,
workflowYaml and the Severity type, still consumed by those demo views,
plus the starterIds/demoIds tables that mirror
packages/database/src/seed-data.ts.
- components/severity.tsx, still imported by investigation-view.tsx.
No behaviour change: typecheck, lint, test and build are clean, and the
/rooms, /rooms/[slug], /rooms/admin and /search routes still build and
still redirect to /.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
room-agent-activity, room-agent-handoffs, and visual-reaction-asset were imported only by room-view.tsx. agent-handoff-card stays: tasks-view still uses it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (12)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Phase 4 of 6. Deletion only — no behaviour change.
ADR 0006 removed chat and room UI from the product surface. The page files became unconditional
redirect()s, but their component trees were never deleted. ~7,100 lines of code nobody could reach, still importing demo fixtures and still full of "not available yet" buttons — misleading to anyone reading the repo.Deleted
room-view.tsxroom-composer.tsxrooms-browser.tsxapp-shell.tsxroom-agent-activity.tsxroom-admin-view.tsxsearch-view.tsxcommand-palette.tsxroom-agent-handoffs.tsxvisual-reaction-asset.tsxoperations-chart.tsxPlus 722 lines pruned from
lib/demo-data.ts(14 exports whose only consumers were the deleted components). That file goes 1092 → 370.The last three were second-order: orphaned by the
room-viewdeletion itself.agent-handoff-card.tsxwas in that set but survives —tasks-view.tsxstill imports it.Kept, deliberately
/rooms,/rooms/[slug],/rooms/admin, and/searchstill emit and still redirect.investigation-view,integration-view,workflows-view. These are not dead — they render whenMUSTER_DEMO_MODE=true. An earlier read of mine called the whole set unreachable; that was only true with demo mode off. They are untouched.demo-data.tssurvivors (Severity,demoMode,activeInvestigation,workflows,workflowYaml,integrationData) — still imported by those demo views. ThestarterIds/demoIdstables also stay: they mirrorpackages/database/src/seed-data.ts, so trimming their now-unreferenced fields would degrade a deliberate mirror rather than remove dead UI.severity.tsx— still imported byinvestigation-view.tsx.Verification
Import graph re-checked by grep against the branch after deletion: no dangling reference to any removed module.
pnpm typecheck,pnpm lint,pnpm test, andpnpm buildall clean — build being the one that matters here, since a dangling import is the exact failure mode of this change.🤖 Generated with Claude Code