-
Notifications
You must be signed in to change notification settings - Fork 305
Update messaging spec #1095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update messaging spec #1095
Conversation
…kernel message specification
8b05ef7 to
2118bab
Compare
minrk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
|
For previous client bindings that used PUB/SUB sockets for IOPub, will they be backwards compatible or do they need to be able to detect that the version is 5.5 somehow? Based on reading Impact on Existing Implementations, it seems like I should add this into the jupyter rust crates ( For now I'll add the message in to the Rust crate in runtimed/runtimed#203 and come up with a plan for how I can support XPUB kernels maybe optionally at first (?). |
|
If a kernel speaks protocol version 5.4 and uses a PUB socket, the |
| between the frontend and the kernel to ensure that they are still connected. | ||
|
|
||
| .. versionchanged:: 5.5 | ||
| The **IOPub** PUB socket is replaced with an XPUB socket. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The **IOPub** PUB socket is replaced with an XPUB socket. | |
| The **IOPub** PUB socket is replaced with an XPUB socket, | |
| to enable the `iopub_welcome` message. | |
| There is no other difference between kernel PUB and XPUB sockets from the client perspective. |
This adds the missing specification for the accepted JEPS of these last years, in order to make a new release of the specification. I'll make a separate PR for the handshaking and the regular connection patterns.