Repository navigation
Conversation
Apply merged units (defaults + _custom_units) at view creation so units added before the control displays are honored; re-initialize the control on change:_custom_units so add_length_unit/add_area_unit work after display too. Also fix secondar_area_unit typo in model defaults. Fixes jupyter-widgets#1264
Author
|
Closing this one so it does not sit in the queue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MeasureControl.add_length_unithas no effect. Two independent causes, both inpython/jupyter_leaflet/src/controls/MeasureControl.ts.The model default is spelled
secondar_area_unit, missing they. Anything readingsecondary_area_unittherefore falls through to undefined regardless of what the user set.And
create_objbuilds the Leaflet control withget_options(), which carries the base controloptions rather than the measure-specific ones. Custom units synced from Python before the view exists
are in the measure options, so they were never passed. The control is re-initialised with
get_measure_control_options()after construction, which is what applies them.Both were needed: fixing the typo alone still loses units set before view creation, and
re-initialising alone still cannot see an area unit stored under a misspelled key.
Fixes #1264