Skip to content

Pin sphinx, xarray version - #1276

Merged
martinRenou merged 3 commits into
jupyter-widgets:masterfrom
nakul-py:test
May 7, 2026
Merged

martinRenou merged 3 commits into
jupyter-widgets:masterfrom
nakul-py:test

Conversation

@nakul-py

@nakul-py nakul-py commented May 6, 2026 •

Copy link
Copy Markdown
Contributor

Pin sphinx, xarray version to fix RTD.

@nakul-py nakul-py changed the title [WIP] Testing CI Pin sphinx, xarray version May 6, 2026

@martinRenou martinRenou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for having a look at this! Let's merge when green

@martinRenou

Copy link
Copy Markdown
Member

Can you please run jlpm run lint && jlpm run prettify locally to fix the linting issue on the CI?

@nakul-py

nakul-py commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

Can you please run jlpm run lint && jlpm run prettify locally to fix the linting issue on the CI?

I don't think it's a lint issue from the error we get is from matchsnapshots failure. and we don't have any script related to lint in project.

@martinRenou

Copy link
Copy Markdown
Member

Too much task switching, I've not commented the right PR sorry!!

@nakul-py
nakul-py requested a review from martinRenou May 6, 2026 10:09

@martinRenou martinRenou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou
martinRenou merged commit efafacc into jupyter-widgets:master May 7, 2026
4 checks passed
@nakul-py
nakul-py deleted the test branch May 7, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants