fix docker publish workflow to use the release zip for the tag being built#126
Open
mooncitydev wants to merge 1 commit into
Open
fix docker publish workflow to use the release zip for the tag being built#126mooncitydev wants to merge 1 commit into
mooncitydev wants to merge 1 commit into
Conversation
the workflow runs on tag push but was downloading the latest release asset, so a rebuild of an older tag could ship a newer binary inside an older image tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey team, was looking at the publish workflow and noticed something off.
when you push a tag, the workflow tags the docker image with that tag (via metadata-action), but the step that downloads the binary zip uses
version: latestinstead of the tag that triggered the run. so if you ever rebuild an older tag, or releases get created out of order, you can end up with e.g.ghcr.io/.../metis-binary:v7.0.10that actually contains the v7.0.14 binary inside. pretty easy to miss until someone debugs a version mismatch in prod.this changes it to
tags/${{ github.ref_name }}so the zip always matches the tag push. also pinned fetch-gh-release-asset to 1.1.2 instead of@master.cheers