Fix: Read File Already Closed#20
Open
ex-preman wants to merge 4 commits into
Open
Conversation
ex-preman
commented
May 19, 2021
- Fix read file already closed
- Move to dep from go mod
- Floating coverage precision and validation
added 4 commits
May 19, 2021 00:20
- Fix read file already closed - Move go dep to go mod - Increase floating coverage precision
Owner
|
Hi @ex-preman, sorry for the delay I've been very backlogged with work. Thanks for your contribution, however I cannot merge this PR at this time, as it has too many different changes all included at once. Can you please separate each major change into its own PR, and then I will be able to review them. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.