Skip to content

test#4

Open
PedjaT-zv wants to merge 3 commits into
jonreiter:masterfrom
Z1Tech-io:feature/serbian-translation
Open

test#4
PedjaT-zv wants to merge 3 commits into
jonreiter:masterfrom
Z1Tech-io:feature/serbian-translation

Conversation

@PedjaT-zv

Copy link
Copy Markdown

No description provided.

@PedjaT-zv

Copy link
Copy Markdown
Author

test

@jonreiter

Copy link
Copy Markdown
Owner

supporting multiple languages sounds great. but probably not at the expense of overwriting the original.

given the hard-coded nature of the whole thing offering a flag or so to switch data sets would presumably be fine. but at least split it out somehow please.

@PedjaT-zv

Copy link
Copy Markdown
Author

I made it work on Serbian Language, but I needed to translate whole lexicon file and some constants. I removed hard-coded []bytes and imported new file which works fine for now.

I don't want to merge on your repository, i don't know how i ended up here with commits, just wanted to merge to our forked repository xD

@PedjaT-zv

Copy link
Copy Markdown
Author

I didn't selected right repository, it was yours by default. Sorry about that :) Regards

@jonreiter

Copy link
Copy Markdown
Owner

ok no problem. out of curiosity: does it seem to work well? i imagine cj hutto would be interested to hear if its working as english and serbian are not v closely related and it's not obvious just swapping words is enough.

@PedjaT-zv

Copy link
Copy Markdown
Author

Yes, it's working fine for me, my clients wants to calculate text emotional score with Vader algorithm and I made it work on Serbian. They are satisfied with results. I translated vaderLexicon.txt to Serbian and static phrases too, added some our words with emotional score in lexicon file and it's rolling fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants