Add Schnorr digest signing support for P2TR addresses - #39
Merged
Conversation
- Introduced `sign_schnorr_digest` method in the `Signer` trait to allow signing of application-provided 32-byte BIP-340 digests. - Implemented the method in `KeystoreSigner`, ensuring it validates the P2TR address and derives the appropriate key. - Added `message_signing` capability to `SignerCaps` to indicate support for digest signing. - Created `SchnorrDigestSignature` struct to encapsulate the result of the signing operation, including the address, output key, and signature.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…for atomic exchanges
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sign_schnorr_digestmethod in theSignertrait to allow signing of application-provided 32-byte BIP-340 digests.KeystoreSigner, ensuring it validates the P2TR address and derives the appropriate key.message_signingcapability toSignerCapsto indicate support for digest signing.SchnorrDigestSignaturestruct to encapsulate the result of the signing operation, including the address, output key, and signature.