Replace cfg(all())/cfg(any()) with cfg(true)/cfg(false) - #995
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #995 +/- ##
==========================================
+ Coverage 68.88% 68.91% +0.03%
==========================================
Files 38 38
Lines 9766 9777 +11
==========================================
+ Hits 6727 6738 +11
Misses 3039 3039 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jonasbb
changed the title
cfg(all())/cfg(any()) with cfg(true)/cfg(false)`cfg(all())/cfg(any()) with cfg(true)/cfg(false)
jonasbb
force-pushed
the
cfg-boolean
branch
2 times, most recently
from
August 9, 2026 21:10
8c8d0d4 to
1daa9fa
Compare
This makes the meaning clearer and is supported since Rust 1.88. Ensure that `serde_as` knows how to deal with `cfg(true)`/`cfg(false)`. For the `schemars` support it can understand `cfg_attr` and thus needs to parse `true`/`false` as well. This is not covered by the `syn::Meta` type, so we need to add a new type `CfgAttrCondition` that can represent `true`/`false` as well as the generic `Meta` expression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the meaning clearer and is supported since Rust 1.88.
Ensure that
serde_asknows how to deal withcfg(true)/cfg(false). For theschemarssupport it can understandcfg_attrand thus needs to parsetrue/falseas well. This is not covered by thesyn::Metatype, so we need to add a new typeCfgAttrConditionthat can representtrue/falseas well as the genericMetaexpression.