Repository navigation
Remove standalone Profession page, improve Account table - #35
Merged
Merged
Conversation
Profession.tsx and its /profession route/nav link are gone -- professions are now clickable directly from the Account table instead. AltTable's now-unreachable 'profession' branch is removed along with PageType's now-single-value union. AccountTable: row numbers, Profession 1/2 cells link to SingleProfession when learned, rows sorted by level then ilvl descending.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Profession.tsx, its/professionroute, and its sidebar nav link — professions are now clickable directly from the Account table instead of needing a separate page.AltTable's now-unreachable'profession'branch removed,PageTypetrimmed to its now-single value ('gear').AccountTable: added a row-number column, Profession 1/2 cells link toSingleProfessionwhen learned (no link when "Missing"), rows sorted client-side by level descending then ilvl descending.Test plan
tsc --noEmit— cleannpm test -- --watchAll=false— 12 passednpm run build— compiles successfullynpm run lint(oxlint) /npm run format:check(prettier) — clean