Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revival of leanprover-community#26389 (as discussed — co-authoring).
What this does: adapts
Perfectoid.leanto the current master API so it compiles again:structure S extends P : Prop→structure S : Prop extends P(new syntax)UniformAddGroup→IsUniformAddGroup,TopologicalDivisionRing→IsTopologicalDivisionRing: Type extendsclasses𝒪[K]notation and theValuedfield names verified against current master (no changes needed)State: compiles against master, 13
sorrys remain — the mathematical work:valuedPerfectoidField.is_topological_valuationIsTopologicalNilpotent,val_p_lt_1Tiltfield instancePerfectoidField.isAlgClosed_iff_isAlgClosed_tiltProposal: I take the sorries in order (starting with
val_p_lt_1and the Frobenius-surjectivity API), you review. Happy to push directly to your branch instead if you prefer.