Skip to content

WIP proposed use of {rsvg} (continued) - #31

Open
jimjam-slam wants to merge 7 commits into
mainfrom
feature-newflags
Open

WIP proposed use of {rsvg} (continued)#31
jimjam-slam wants to merge 7 commits into
mainfrom
feature-newflags

Conversation

@jimjam-slam

Copy link
Copy Markdown
Owner

Looks like the two branches are the same apart from store_flags.r and lflags.rda, so I'm not sure why one works and one doesn't =_=

@jimjam-slam

Copy link
Copy Markdown
Owner Author

It seems like the .rda file being produced with the new store_flags.R code on feature-newflags is not loading back in properly—it doesn't produce an error, but no objects populate the environment.

new_env <- new.env(parent = emptyenv())
load("lflags.rda", envir = new_env)
ls(new_env)
# character(0)

@jimjam-slam

Copy link
Copy Markdown
Owner Author

Got a trip from runapp colleagues: the store_flags script needs to store an object named lflags into lflags.rda, not .flaglist (as the rest of the package now refers to ggflags::lflags, not .flaglist. So I'll update it and see how we go!

(New flag masks still not working)
@jimjam-slam

Copy link
Copy Markdown
Owner Author

I haven't included the new flag rda file yet, but commit 0832c6d fixes the store_flag script and the package DESCRIPTION to make the new flags load properly.

I had to add compression, as librsvg currently replaces the vector mask with a base64-encoded one that is huge. Not sure how to get around that other than manually patching the vector mask back in.

Also, the masks still aren't rendering, giving us square flags 🙁

@jimjam-slam

Copy link
Copy Markdown
Owner Author

I won't close this yet, but consider #36 the active PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant