fix(form): correct .control selector edge case for last-child grouping (#4045)#4046
Open
Jlawl1et wants to merge 3 commits into
Open
fix(form): correct .control selector edge case for last-child grouping (#4045)#4046Jlawl1et wants to merge 3 commits into
Jlawl1et wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bugfix.
Proposed solution
Fix incorrect addon behavior in .control grouping when non-.control siblings (e.g. label) are present. Structural pseudo-classes (:last-child, :only-child, etc.) are replaced with their :of-type equivalents to avoid interference from non-control elements.
Tradeoffs
:of-type is based on element type, not class. Edge cases may still occur if other sibling elements share the same tag name.
Testing Done
Manual test with a label followed by a single .control. Verified correct addon behavior.
Changelog updated?
No.
Issue
Fixes #4045