Skip to content

Remove vendor prefixes from sass #3931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jnoordsij wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove vendor prefixes from sass #3931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
220c0ad
Replace placeholder mixin with pseudo-element
jnoordsij Oct 30, 2024
3884129
Remove some vendor-prefixed selectors from sass
jnoordsij Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sass/base/skeleton.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ input.#{iv.$class-prefix}is-skeleton,
textarea.#{iv.$class-prefix}is-skeleton {
resize: none;

@include mx.placeholder {
&::placeholder {
color: transparent !important;
}
}
Expand Down
4 changes: 2 additions & 2 deletions sass/form/shared.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ $input-radius: cv.getVar("radius") !default;
#{cv.getVar("input-color-l")}
);

@include mx.placeholder {
&::placeholder {
color: cv.getVar("input-placeholder-color");
}

Expand Down Expand Up @@ -167,7 +167,7 @@ $input-radius: cv.getVar("radius") !default;
box-shadow: none;
color: cv.getVar("input-disabled-color");

@include mx.placeholder {
&::placeholder {
color: cv.getVar("input-disabled-placeholder-color");
}
}
Expand Down
19 changes: 0 additions & 19 deletions sass/utilities/mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,16 +222,6 @@
-webkit-overflow-scrolling: touch;
}

@mixin placeholder {
$placeholders: ":-moz" ":-webkit-input" "-moz" "-ms-input";

@each $placeholder in $placeholders {
&:#{$placeholder}-placeholder {
@content;
}
}
}

@mixin reset {
appearance: none;
background: none;
Expand All @@ -245,16 +235,10 @@

@mixin selection($current-selector: false) {
@if $current-selector {
&::-moz-selection {
@content;
}
&::selection {
@content;
}
} @else {
::-moz-selection {
@content;
}
::selection {
@content;
}
Expand Down Expand Up @@ -432,9 +416,6 @@

@mixin unselectable {
-webkit-touch-callout: none;
-webkit-user-select: none;
-moz-user-select: none;
-ms-user-select: none;
user-select: none;
}

Expand Down