Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #106. This pull request makes several improvements to the way plot markers and legends are handled in the
solarmachplotting functions. The main focus is on enhancing the clarity and maintainability of marker annotations (especially numbered markers) and their representation in the legend. A new custom legend handler is introduced to support this, and redundant or complex code for manual legend positioning is removed.Legend and marker handling improvements:
_NumberedHandlerLine2Dto display marker numbers directly in the legend, making numbered markers clearer and more consistent between the plot and legend.plotandplot_pfssmethods to use this new handler for numbered markers in the legend, replacing manual annotation logic and simplifying code for marker handling. [1] [2]handler_mapand associate handles with the appropriate custom handler, improving maintainability and flexibility. [1] [2]Marker annotation visual tweaks:
Imports:
HandlerLine2Dfrommatplotlib.legend_handlerfor use with the new custom legend handler.