Skip to content

Detect numbers when sorting#779

Open
nwoltman wants to merge 5 commits into
javve:masterfrom
nwoltman:patch-1
Open

Detect numbers when sorting#779
nwoltman wants to merge 5 commits into
javve:masterfrom
nwoltman:patch-1

Conversation

@nwoltman

@nwoltman nwoltman commented Oct 4, 2024

Copy link
Copy Markdown

Fix #562 by checking if the values being sorted are both numbers and sorting them as numbers if they are.

@codecov-commenter

codecov-commenter commented Oct 4, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.60%. Comparing base (d32c85d) to head (5857111).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #779      +/-   ##
==========================================
+ Coverage   93.54%   93.60%   +0.05%     
==========================================
  Files          19       19              
  Lines         837      844       +7     
  Branches      199      201       +2     
==========================================
+ Hits          783      790       +7     
  Misses         38       38              
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not sorting negative numbers correctly. Reproduced on listjs.com

2 participants