Prevent pagination buttons from scrolling to top#750
Open
dregad wants to merge 2 commits into
Open
Conversation
Fixes a regression introduced by javve#499, causing the browser to scroll to the top of the page when the pagination buttons are clicked.
dregad
added a commit
to dregad/mantisbt
that referenced
this pull request
Jun 7, 2022
This is the patch submitted upstream [[1]]. Fixes #30494 [1]: javve/list.js#750
dregad
added a commit
to dregad/mantisbt
that referenced
this pull request
Jun 12, 2022
This is the patch submitted upstream [[1]]. Fixes #30494 [1]: javve/list.js#750
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #750 +/- ##
==========================================
- Coverage 93.54% 93.43% -0.12%
==========================================
Files 19 19
Lines 837 838 +1
Branches 199 199
==========================================
Hits 783 783
- Misses 38 39 +1
Partials 16 16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
The initial commit prevented the click event's execution of for all the List's objects. This causes problems e.g. when the list contains clickable elements such as checkboxes, which become unusable. |
Author
|
@javve any chance this could be merged ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced by #499, causing the browser to scroll to
the top of the page when the pagination buttons are clicked.