Use portable-atomic in cs.rs for ESP32 compatibility #123
+10
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The critical-section coordination module (cs.rs) was using core::sync::atomic types directly, which don't work on targets like riscv32imc (ESP32-C3) that lack native atomic support. This change: - Uses portable-atomic for AtomicBool and AtomicUsize in cs.rs - Adds portable-atomic as an optional dependency enabled by the critical-section feature - Removes maitake-sync?/critical-section propagation since cs.rs doesn't need it, and it enables portable-atomic/critical-section which conflicts with esp-hal's unsafe-assume-single-core cfg This allows bbqueue to work on ESP32 chips where esp-hal configures portable-atomic with unsafe-assume-single-core for atomic operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The critical-section coordination module (cs.rs) was using core::sync::atomic types directly, which don't work on targets like riscv32imc (ESP32-C3) that lack native atomic support.
This change:
This allows bbqueue to work on ESP32 chips where esp-hal configures portable-atomic with unsafe-assume-single-core for atomic operations.