-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Refactor: SpotLightShadowRenderer reduce object allocations #2515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Refactor: SpotLightShadowRenderer reduce object allocations #2515
Conversation
|
🖼️ Screenshot tests have failed. The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests. 📄 Where to find the report:
✅ If you did mean to change things: ✨ If you are creating entirely new tests: Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar". See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information |
jme3-core/src/main/java/com/jme3/shadow/SpotLightShadowRenderer.java
Outdated
Show resolved
Hide resolved
riccardobl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the minor issues in this PR are resolved now, should be good to go
This PR refactors the
SpotLightShadowRendererclass to improve code readability, consistency, and performance. Key changes include:Camera[] camerasin methods with a class-level field to avoid redundant allocations.These changes do not modify the core logic or functionality but streamline the implementation and improve maintainability.