Skip to content

Improve dismissing ScrollView #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ivanvorobei merged 3 commits into from
Jul 5, 2019
Merged

Improve dismissing ScrollView #79

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a9f0d1
Add support for ViewController inside UINavigationController
dstranz Jul 2, 2019
b6c7031
Add tableView header position fix
dstranz Jul 2, 2019
f44e2bb
Move whole UIScrollView to fix issue with floating header
dstranz Jul 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions Source/SPStorkController/SPStorkController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,13 @@
import UIKit

public enum SPStorkController {

static public func scrollViewDidScroll(_ scrollView: UIScrollView) {
if let controller = self.controller(for: scrollView) {
if let presentationController = controller.presentationController as? SPStorkPresentationController {
if let presentationController = self.presentationController(for: controller) {
let translation = -(scrollView.contentOffset.y + scrollView.contentInset.top)
if translation >= 0 {
if controller.isBeingPresented { return }
scrollView.subviews.forEach {
$0.transform = CGAffineTransform(translationX: 0, y: -translation)
}
scrollView.transform = CGAffineTransform(translationX: 0, y: -translation)
presentationController.setIndicator(style: scrollView.isTracking ? .line : .arrow)
if translation >= presentationController.translateForDismiss * 0.4 {
if !scrollView.isTracking && !scrollView.isDragging {
Expand Down Expand Up @@ -74,6 +71,18 @@ public enum SPStorkController {
}
}

static private func presentationController(for controller: UIViewController) -> SPStorkPresentationController? {
if let presentationController = controller.presentationController as? SPStorkPresentationController {
return presentationController
}

if let presentationController = controller.parent?.presentationController as? SPStorkPresentationController {
return presentationController
}

return nil
}

static private func controller(for view: UIView) -> UIViewController? {
var nextResponder = view.next
while nextResponder != nil && !(nextResponder! is UIViewController) {
Expand Down