Skip to content

Adding feature to dismiss when pan on UIScrollView with UIStackView #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tavernari wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adding feature to dismiss when pan on UIScrollView with UIStackView #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
895439f
added feature to close when pan on UIScrollView
VictorTavernariEV Jul 1, 2019
f373439
updating readme
VictorTavernariEV Jul 1, 2019
3ccdd10
removed unsed code
VictorTavernariEV Jul 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,8 @@ pod 'SPFakeBar'

If you use `UIScrollView` (or UITableView & UICollectionView) on controller, I recommend making it more interactive. When scrolling reaches the top position, the controller will interactively drag down, simulating a closing animation. Also available close controller by drag down on `UIScrollView`. To do this, set the delegate and in the function `scrollViewDidScroll` call:

To enable swipe down you have to enable bounce on top.

```swift
func scrollViewDidScroll(_ scrollView: UIScrollView) {
SPStorkController.scrollViewDidScroll(scrollView)
Expand Down
2 changes: 2 additions & 0 deletions Source/SPStorkController/SPStorkController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,12 @@ public enum SPStorkController {
return
}
}

if presentationController.pan?.state != UIGestureRecognizer.State.changed {
presentationController.scrollViewDidScroll(translation * 2)
}
} else {
presentationController.updatePresentedViewForTranslation(inVerticalDirection: translation)
presentationController.setIndicator(style: .arrow)
presentationController.scrollViewDidScroll(0)
}
Expand Down
2 changes: 1 addition & 1 deletion Source/SPStorkController/TransitioningDelegate/SPStorkPresentationController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ extension SPStorkPresentationController {
})
}

private func updatePresentedViewForTranslation(inVerticalDirection translation: CGFloat) {
func updatePresentedViewForTranslation(inVerticalDirection translation: CGFloat) {
if self.startDismissing { return }

let elasticThreshold: CGFloat = 120
Expand Down